Logging to a console and a file in a Win32 C++ GUI application

[TheoLogic]

http://www.theologic.eu/CPP/Logger/Logging%20to%20a%20console%20and%20a%20file%20in%20a%20Win32%20C++%20GUI%20application.pdf

[oulyt]

i dont know what half of those headers are yet and a bunch of that code but it was good reading. thanks

[adeyblue]

Looks like it's not quite finished

Remark the includes needed to create, show and write to the console.

Remark we use “try-catch” error handling.

I noticed you're using the potentially buggy code that everyone seems to find for adding a console and opening the standard handles. Casting the handles to long instead of intptr_t could chop the values in half on 64-bit Windows leaving them with the wrong values.

Also:

Code

GeSHi (cpp):
GetConsoleTitle(static_cast<LPWSTR>(sConsoleWindowName), 1024);
hConsole = FindWindow(NULL, sConsoleWindowName);
[/url]
can be just
[source=cpp]
hConsole = GetConsoleWindow();
[/source]
Created by GeSHI 1.0.7.18

[TheoLogic]

This is true, but I cropped the code where I set the consolewindows's name
Offcourse, many ways to do this, but I haven't got any problems with this...

[myork]

A file and the console are just streams.
You could simply write a simple wrapper that sent data to both!

Code:

class TwoOutputs
{
    public: TwoOutputs(std::ostream& one,std::ostream& two)
                  : m_one(one)
                  , m_two(two)
              {}

        std::ostream& m_one;
        std::ostream& m_two;
};

template<typename T>
TwoOutputs& operator<<(TwoOutputs& dst,T const& data)
{
    dst.m_one << data;
    dst.m_two << data;

    return *this;
}

int main()
{
    std::ofstream   file(plop);
    TwoOutputs     log(file,std::cerr);

    log << "Output To both streams\n";
};

[TheoLogic]

Agreed, but I think your code is pretty unreadable for beginners C++, and you'd still need RAII for safe writting to a file. But this idea is a good thing to think about.
Keep the remarks comming!